spencer/envr
1
0
Fork 0
mirror of https://github.com/sbrow/envr.git synced 2026-06-27 18:48:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fixed logic bug in db.

Browse Source
This commit is contained in:
Spencer Brower
2026-06-12 17:16:51 -04:00
parent d620e2646e
commit b7fdb88f34
4 changed files with 38 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
TODOS.md
View File

@@ -10,8 +10,6 @@ Note: These todos can wait until all the subcommands have been ported.
30. **cmd_sync.odin:46-50, 64-68** — Double `db_insert` when `BackedUp`: first insert on line 48, then `db_update_required` is also true for `BackedUp` so second insert runs on line 65. Redundant and wasteful.
31. **db.odin:626 & env_file.go:183** — `BackedUp` discards `DirUpdated`. When `TrustFilesystem` is used and the hash differs, the result is just `BackedUp` (not `BackedUp | DirUpdated`). If a file's directory was moved AND its contents changed, the old DB entry won't be deleted because the `DirUpdated` check at `cmd_sync.odin:59` never fires. Bug exists in both Go and Odin.
## MEDIUM
4. **db.odin:29-35** — `make_temp_path` never calls `strings.builder_destroy`. Leaks builder buffer every call.