docs: Removed completed TODOs.

test: Table tests now view full output.
test: commands now accept stdout/stderr fields.
2026-06-27 18:48:33 -04:00 · 2026-06-15 19:34:59 -04:00 · 2026-06-15 19:28:56 -04:00 · 2026-06-15 19:26:44 -04:00 · 2026-06-15 16:45:36 -04:00
23 changed files with 403 additions and 328 deletions
--- a/TODOS.md
+++ b/TODOS.md
@@ -4,67 +4,55 @@ Note: These todos can wait until all the subcommands have been ported.

 ## HIGH

-2. **db.odin:380-383, 405, 446** — `sqlite.bind_text` return values overwritten but never checked. A failed bind means `sqlite.step` operates on unbound params.
-
-3. **config.odin:52-54** — `os.user_home_dir` error silently ignored. If it fails, `home` is `""` and all paths become relative (`".envr"` instead of `"~/.envr"`).
+1. **db.odin:380-383, 405, 446** — `sqlite.bind_text` return values overwritten but never checked. A failed bind means `sqlite.step` operates on unbound params.

 ## MEDIUM

-4. **db.odin:29-35** — `make_temp_path` never calls `strings.builder_destroy`. Leaks builder buffer every call.
+2. **db.odin:324-327** — Map iteration (`remote_set`) is non-deterministic. Same file can produce different JSON on each backup, causing spurious DB diffs. Sort remotes before storing.

-5. **db.odin:324-327** — Map iteration (`remote_set`) is non-deterministic. Same file can produce different JSON on each backup, causing spurious DB diffs. Sort remotes before storing.
+3. **db.odin:135, 250** — String interpolation into SQL (`VACUUM INTO '%s'`, `ATTACH DATABASE '%s'`). Currently safe because input is controlled, but fragile.

-6. **db.odin:470-473** — `string_to_cstring` allocates via `strings.clone_to_cstring` and never frees. Called dozens of times across db operations.
+4. **features.odin:30-41** — `find_binary` uses `strings.join` instead of `filepath.join`, uses `os.stat` instead of checking executability, hardcodes `:` as PATH separator (wrong on Windows).

-7. **db.odin:470, 462** — Both `string_to_cstring` and `cstring_to_string` ignore allocation errors. A nil cstring gets passed to SQLite (UB).
+5. **cmd_restore.odin:20-30 & cmd_remove.odin:19-29** — Identical path-resolution block copy-pasted. `is_abs` guard is redundant since `filepath.abs` is a no-op on absolute paths. Extract a helper.

-8. **db.odin:135, 250** — String interpolation into SQL (`VACUUM INTO '%s'`, `ATTACH DATABASE '%s'`). Currently safe because input is controlled, but fragile.
+6. **cmd_restore.odin:44** — `os.mkdir_all` error silently discarded. Subsequent write failure will be confusing.

-9. **features.odin:30-41** — `find_binary` uses `strings.join` instead of `filepath.join`, uses `os.stat` instead of checking executability, hardcodes `:` as PATH separator (wrong on Windows).
+7. **cmd_edit_config.odin:27** — `$EDITOR` used as single binary name. Breaks for multi-word values like `"code -w"`. Needs `strings.fields()`.

-10. **cmd_restore.odin:20-30 & cmd_remove.odin:19-29** — Identical path-resolution block copy-pasted. `is_abs` guard is redundant since `filepath.abs` is a no-op on absolute paths. Extract a helper.
+8. **config.odin:178** — `search_paths` silently ignores `os.user_home_dir` error. If home is empty, `~` isn't expanded. Same class of bug as issue 3.

-11. **cmd_restore.odin:44** — `os.mkdir_all` error silently discarded. Subsequent write failure will be confusing.
-
-12. **cmd_edit_config.odin:27** — `$EDITOR` used as single binary name. Breaks for multi-word values like `"code -w"`. Needs `strings.fields()`.
-
-33. **config.odin:178** — `search_paths` silently ignores `os.user_home_dir` error. If home is empty, `~` isn't expanded. Same class of bug as issue 3.
-
-35. **prompt.odin:124** — `make([dynamic]bool, len(options))` creates N zero-initialized elements. Works because `false` is the default, but same footgun as original issue 1. Should be `make([dynamic]bool, 0, len(options))`.
-
-39. Lots of memory leaks to fix.
+9. **prompt.odin:124** — `make([dynamic]bool, len(options))` creates N zero-initialized elements. Works because `false` is the default, but same footgun as original issue 1. Should be `make([dynamic]bool, 0, len(options))`.

 ## LOW

-15. **db.odin:115** — `json.unmarshal_string` error not checked. Malformed JSON silently produces empty/partial data.
+10. **db.odin:115** — `json.unmarshal_string` error not checked. Malformed JSON silently produces empty/partial data.

-16. **db.odin:352-353** — `hex.encode` error ignored. `string(hex_bytes)` aliases the byte slice.
+11. **db.odin:352-353** — `hex.encode` error ignored. `string(hex_bytes)` aliases the byte slice.

-18. **config.odin:51-60** — `envr_dir` recomputes home dir on every call. Could cache.
-
-37. **cmd_sync.odin:80, cmd_list.odin:33, cmd_deps.odin:9** — `make([]string, 2)` for table rows never freed. Leaks per row. Defer to memory pass.
+12. **cmd_sync.odin:80, cmd_list.odin:33, cmd_deps.odin:9** — `make([]string, 2)` for table rows never freed. Leaks per row. Defer to memory pass.

 ## REFACTOR

-20. **cmd_list.odin** — Non-TTY branch builds `ListEntry` structs and marshals JSON separately. Now that `render_json_rows` (issue 1) accepts an `io.Writer` and uses `json.marshal`, unify both branches to use it. Note: will change JSON keys from `"directory"/"path"` to `"Directory"/"Path"`.
+13. **cmd_list.odin** — Non-TTY branch builds `ListEntry` structs and marshals JSON separately. Now that `render_json_rows` (issue 1) accepts an `io.Writer` and uses `json.marshal`, unify both branches to use it. Note: will change JSON keys from `"directory"/"path"` to `"Directory"/"Path"`.

-21. Check for prealloc opportunities. i.e. `make([dynamic]string)` -> `make([dynamic]string, 5)`.
+14. Check for prealloc opportunities. i.e. `make([dynamic]string)` -> `make([dynamic]string, 5)`.

-23. Add a text filter to the multi_select.
+15. Add a text filter to the multi_select.

-24. Create backup / fallback fd.
+16. Create backup / fallback fd.

-25. Add tests for untested commands.
+17. Add tests for untested commands.

-28. 2 scan tests silently skip when fd isn't installed, tests pass without actually testing anything. These should use #assert to be sure that fd is in path.
+18. 2 scan tests silently skip when fd isn't installed, tests pass without actually testing anything. These should use #assert to be sure that fd is in path.

-38. Try to do all encryption / decryption in memory - only read / write encrypted data to disk.
+19. Try to do all encryption / decryption in memory - only read / write encrypted data to disk.

-40. use a buffered writer where possible (mem.DEFAULT_PAGE_SIZE)
+20. add --format -f flag to commands that draw tables.

-41. add --format -f flag to commands that draw tables.
+21. Replace `testing.expect` calls with `testing.expect_value` calls where appropriate.

-42. Replace `testing.expect` calls with `testing.expect_value` calls where appropriate.
+22. Change struct field names from PascalCase to snake_case.

 ## Double-check AI output

--- a/cli.odin
+++ b/cli.odin
@@ -3,7 +3,6 @@ package main
 import "core:bufio"
 import "core:fmt"
 import "core:io"
-import "core:mem"
 import "core:os"
 import "core:strings"

@@ -13,6 +12,9 @@ Command :: struct {
 	flags:       map[string]string,
 	bool_set:    map[string]bool,
 	config_path: string,
+	out_buf:     ^bufio.Writer,
+	out:         io.Writer,
+	err:         io.Writer,
 }

 CommandInfo :: struct {
@@ -28,7 +30,10 @@ COMMANDS := []CommandInfo {
 		"init",
 		"envr init",
 		"Set up envr",
-		"The init command generates your initial config and saves it to\n~/.envr/config in JSON format.\n\nDuring setup, you will be prompted to select one or more ssh keys with which to\nencrypt your databse. **Make 100% sure** that you have **a remote copy** of this\nkey somewhere, otherwise your data could be lost forever.",
+		`The init command generates your initial config and saves it to
+~/.envr/config in JSON format.\n\nDuring setup, you will be prompted to select one or more ssh keys with which to
+encrypt your databse. **Make 100% sure** that you have **a remote copy** of this
+key somewhere, otherwise your data could be lost forever.`,
 		{},
 	},
 	{"scan", "envr scan", "Find and select .env files for backup", "", {}},
@@ -56,11 +61,27 @@ COMMANDS := []CommandInfo {
 	},
 }

+delete_command :: proc(cmd: ^Command) {
+	delete(cmd.args)
+	delete(cmd.flags)
+	delete(cmd.bool_set)
+	bufio.writer_destroy(cmd.out_buf)
+	free(cmd.out_buf)
+}
+
+// Caller is responsible for calling delete_command(cmd).
 // FIXME: Works in kinda a wonky and awkward way.
-parse_args :: proc(args: []string) -> (cmd: Command, ok: bool) {
+parse_args :: proc(args: []string, out: io.Stream, err: io.Stream) -> (cmd: Command, ok: bool) {
+	{
+		cmd.out_buf = new(bufio.Writer)
+		bufio.writer_init(cmd.out_buf, out)
+		cmd.out = bufio.writer_to_writer(cmd.out_buf)
+		cmd.err = err
+	}
+
 	if len(args) < 2 || args[1] == "--help" || args[1] == "-h" {
-		print_usage()
-		return Command{}, false
+		write_usage(cmd.out)
+		return cmd, false
 	}

 	cmd.name = args[1]
@@ -102,13 +123,15 @@ parse_args :: proc(args: []string) -> (cmd: Command, ok: bool) {
 		cmd.config_path = val
 	} else {
 		// FIXME: Handle err
-		home, _ := os.user_home_dir(context.allocator)
-		cmd.config_path = default_config_path(home)
+		// TODO: Is this right?
+		home, _ := os.user_home_dir(context.temp_allocator)
+		// TODO: should we copy out of the temp_allocator?
+		cmd.config_path = default_config_path(home, context.temp_allocator)
 	}

 	if has_flag(&cmd, "help") {
-		print_command_help(cmd.name)
-		return Command{}, false
+		print_command_help(&cmd)
+		return cmd, false
 	}

 	return cmd, true
@@ -167,18 +190,12 @@ write_command_help :: proc(name: string, w: io.Writer) -> bool {
 	return true
 }

-print_command_help :: proc(name: string) {
-	bw: bufio.Writer
-	bufio.writer_init(&bw, io.to_writer(os.to_writer(os.stdout)), mem.DEFAULT_PAGE_SIZE)
-	defer bufio.writer_destroy(&bw)
-
-	w := bufio.writer_to_writer(&bw)
-	ok := write_command_help(name, w)
+print_command_help :: proc(cmd: ^Command) {
+	ok := write_command_help(cmd.name, cmd.out)
 	if !ok {
-		fmt.printf("Unknown command: %s\n", name)
-		print_usage()
+		fmt.wprintf(cmd.err, "Unknown command: %s\n", cmd.name)
+		write_usage(cmd.out)
 	}
-	bufio.writer_flush(&bw)
 }

 // TODO: command args should be shown in usage.
@@ -253,13 +270,3 @@ Use "envr [command] --help" for more information about a command.
 	)
 }

-// TODO: Look at usages,might want to pass a writer
-print_usage :: proc() {
-	bw: bufio.Writer
-	bufio.writer_init(&bw, io.to_writer(os.to_writer(os.stdout)), mem.DEFAULT_PAGE_SIZE)
-	defer bufio.writer_destroy(&bw)
-	defer bufio.writer_flush(&bw)
-
-	write_usage(bufio.writer_to_writer(&bw))
-}
-
--- a/cli_test.odin
+++ b/cli_test.odin
@@ -2,6 +2,7 @@
 package main

 import "core:bufio"
+import "core:fmt"
 import "core:strings"
 import "core:testing"

@@ -189,29 +190,50 @@ test_has_flag_empty_command :: proc(t: ^testing.T) {
 }

 test_parse_args :: proc(
+	args: []string,
+) -> (
+	cmd: Command,
+	ok: bool,
+	out_text: string,
+	err_text: string,
+) {
+	out_b: strings.Builder
+	strings.builder_init(&out_b)
+	defer strings.builder_destroy(&out_b)
+	err_b: strings.Builder
+	strings.builder_init(&err_b)
+	defer strings.builder_destroy(&err_b)
+
+	cmd, ok = parse_args(args, strings.to_stream(&out_b), strings.to_stream(&err_b))
+
+	if ok {
+		bufio.writer_flush(cmd.out_buf)
+		out_text = strings.to_string(out_b)
+		err_text = strings.to_string(err_b)
+	}
+
+	return
+}
+
+@(test)
 test_parse_args_bare_command :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "list"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect_value(t, cmd.name, "list")
-	testing.expect(t, len(cmd.args) == 0, "should have no positional args")
-	testing.expect(t, len(cmd.flags) == 0, "should have no flags")
-	testing.expect(t, len(cmd.bool_set) == 0, "should have no bool flags")
-}
+	testing.expect_value(t, len(cmd.args), 0)
+	testing.expect_value(t, len(cmd.flags), 0)
+	testing.expect_value(t, len(cmd.bool_set), 0)
+}

@(test)
 test_parse_args_positional :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "backup", "/project/.env"})
-	testing.expect(t, ok, "should succeed")
+	defer delete_command(&cmd)
+	testing.expect(t, ok, "should succeed")

-	defer delete(cmd.args)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
 	testing.expect(t, cmd.name == "backup")
 	testing.expect(t, len(cmd.args) == 1)
 	testing.expect(t, cmd.args[0] == "/project/.env")
@@ -220,60 +242,50 @@ test_parse_args_positional :: proc(t: ^testing.T) {
@(test)
 test_parse_args_long_flag_with_value :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "sync", "--config", "x.json"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(t, cmd.flags["config"] == "x.json")
 }

@(test)
 test_parse_args_short_flag_with_value :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "sync", "-c", "x.json"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(t, cmd.flags["c"] == "x.json")
 }

@(test)
 test_parse_args_long_bool_flag :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "init", "--force"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(t, cmd.bool_set["force"] == true)
 }

@(test)
 test_parse_args_short_bool_flag :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "version", "-l"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(t, cmd.bool_set["l"] == true)
 }

@(test)
 test_parse_args_multiple_positionals :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "backup", "a", "b"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(t, len(cmd.args) == 2)
 	testing.expect(t, cmd.args[0] == "a")
 	testing.expect(t, cmd.args[1] == "b")
@@ -282,12 +294,10 @@ test_parse_args_multiple_positionals :: proc(t: ^testing.T) {
@(test)
 test_parse_args_mixed_flags_and_positionals :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "backup", "/project/.env", "--force"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(t, cmd.bool_set["force"] == true)
 	testing.expect(t, len(cmd.args) == 1)
 	testing.expect(t, cmd.args[0] == "/project/.env")
@@ -296,18 +306,16 @@ test_parse_args_mixed_flags_and_positionals :: proc(t: ^testing.T) {
@(test)
 test_parse_args_no_args :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr"})
-	testing.expect(t, !ok, "no args should return false")
+	defer delete_command(&cmd)
+	testing.expect(t, !ok, "no args should return false")
 }

@(test)
 test_parse_args_flag_then_positional_then_flag :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "backup", "a.env", "--force", "--verbose"})
-	testing.expect(t, ok, "should succeed")
+	defer delete_command(&cmd)
+	testing.expect(t, ok, "should succeed")

-	defer delete(cmd.args)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
 	testing.expect(t, cmd.bool_set["force"] == true)
 	testing.expect(t, cmd.bool_set["verbose"] == true)
 	testing.expect(t, len(cmd.args) == 1)
@@ -317,36 +325,40 @@ test_parse_args_flag_then_positional_then_flag :: proc(t: ^testing.T) {
@(test)
 test_parse_args_config_file_long_flag :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args(
-	testing.expect(t, ok, "should succeed")
+		[]string{"envr", "list", "--config-file", "/custom/config.json"},
+	)
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(
-}
+		t,
+		cmd.config_path == "/custom/config.json",
+		"config_path should be set from --config-file",
+	)
+}

@(test)
 test_parse_args_config_file_short_flag :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "list", "-c", "/custom/config.json"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(
-}
+		t,
+		cmd.config_path == "/custom/config.json",
+		"config_path should be set from -c",
+	)
+}

@(test)
 test_parse_args_config_file_defaults :: proc(t: ^testing.T) {
 	cmd, ok, _, _ := test_parse_args([]string{"envr", "list"})
-	testing.expect(t, ok, "should succeed")
+	testing.expect(t, ok, "should succeed")
 	if !ok do return
 	defer delete_command(&cmd)
-	defer delete(cmd.flags)
-	defer delete(cmd.bool_set)
-
+
 	testing.expect(t, len(cmd.config_path) > 0, "config_path should default to non-empty path")
 	testing.expect(
 		t,
--- a/cmd_backup.odin
+++ b/cmd_backup.odin
@@ -5,13 +5,13 @@ import "core:strings"

 cmd_backup :: proc(cmd: ^Command) {
 	if len(cmd.args) != 1 {
-		print_command_help("backup")
+		print_command_help(cmd)
 		return
 	}

 	path := cmd.args[0]
 	if len(strings.trim_space(path)) == 0 {
-		fmt.println("Error: No path provided")
+		fmt.wprintln(cmd.err, "Error: No path provided", flush = false)
 		return
 	}

@@ -30,6 +30,6 @@ cmd_backup :: proc(cmd: ^Command) {
 		return
 	}

-	fmt.printf("Saved %s into the database\n", path)
+	fmt.wprintf(cmd.out, "Saved %s into the database\n", path, flush = false)
 }

--- a/cmd_check.odin
+++ b/cmd_check.odin
@@ -13,7 +13,7 @@ cmd_check :: proc(cmd: ^Command) {
 	} else {
 		cwd, cwd_err := os.get_working_directory(context.temp_allocator)
 		if cwd_err != nil {
-			fmt.printf("Error getting current directory: %v\n", cwd_err)
+			fmt.wprintf(cmd.err, "Error getting current directory: %v\n", cwd_err, flush = false)
 			return
 		}
 		check_path = cwd
@@ -25,7 +25,7 @@ cmd_check :: proc(cmd: ^Command) {
 	} else {
 		resolved, abs_err := filepath.abs(check_path)
 		if abs_err != nil {
-			fmt.printf("Error getting absolute path: %v\n", abs_err)
+			fmt.wprintf(cmd.err, "Error getting absolute path: %v\n", abs_err, flush = false)
 			return
 		}
 		abs_path = resolved
@@ -43,15 +43,17 @@ cmd_check :: proc(cmd: ^Command) {

 	if is_dir {
 		if cant_scan(feats) {
-			fmt.println(
+			fmt.wprintln(
+				cmd.err,
 				"Error: please install fd to use the check command (https://github.com/sharkdp/fd)",
+				flush = false,
 			)
 			return
 		}

 		scanned, scan_ok := scan_path(abs_path, db.cfg)
 		if !scan_ok {
-			fmt.println("Error scanning directory for .env files")
+			fmt.wprintln(cmd.err, "Error scanning directory for .env files", flush = false)
 			return
 		}
 		files_in_path = scanned
@@ -68,16 +70,15 @@ cmd_check :: proc(cmd: ^Command) {

 	if len(not_backed) == 0 {
 		if len(files_in_path) == 0 {
-			fmt.println("No .env files found in the specified directory.")
+			fmt.wprintln(cmd.out, "No .env files found in the specified directory.", flush = false)
 		} else {
-			fmt.println("✓ All .env files in the directory are backed up.")
+			fmt.wprintln(cmd.out, "✓ All .env files in the directory are backed up.", flush = false)
 		}
 	} else {
-		fmt.printf("Found %d .env file(s) that are not backed up:\n", len(not_backed))
+		fmt.wprintf(cmd.out, "Found %d .env file(s) that are not backed up:\n", len(not_backed), flush = false)
 		for file in not_backed {
-			fmt.printf("  %s\n", file)
+			fmt.wprintf(cmd.out, "  %s\n", file, flush = false)
 		}
-		fmt.println("\nRun 'envr sync' to back up these files.")
+		fmt.wprintln(cmd.out, "\nRun 'envr sync' to back up these files.", flush = false)
 	}
 }
-
--- a/cmd_deps.odin
+++ b/cmd_deps.odin
@@ -1,6 +1,6 @@
 package main

-import "core:io"
+import "core:fmt"
 import "core:os"
 import "core:terminal"

@@ -24,12 +24,10 @@ cmd_deps :: proc(cmd: ^Command) {
 	}

 	if terminal.is_terminal(os.stdout) {
-		w := io.to_writer(os.to_writer(os.stdout))
-		render_table(w, headers, rows[:])
+		render_table(cmd.out, headers, rows[:])
 	} else {
-		w := io.to_writer(os.to_writer(os.stdout))
-		render_json_rows(w, headers, rows[:])
-		io.write_string(w, "\n")
+		render_json_rows(cmd.out, headers, rows[:])
+		fmt.wprint(cmd.out, "\n", flush = false)
 	}
 }

--- a/cmd_edit_config.odin
+++ b/cmd_edit_config.odin
@@ -6,7 +6,7 @@ import "core:os"
 cmd_edit_config :: proc(cmd: ^Command) {
 	editor := os.get_env("EDITOR", context.allocator)
 	if len(editor) == 0 {
-		fmt.println("Error: $EDITOR environment variable is not set")
+		fmt.wprintln(cmd.err, "Error: $EDITOR environment variable is not set", flush = false)
 		return
 	}

@@ -14,7 +14,12 @@ cmd_edit_config :: proc(cmd: ^Command) {

 	_, stat_err := os.stat(config_path, context.allocator)
 	if stat_err != nil {
-		fmt.printf("Config file does not exist at %s. Run 'envr init' first.\n", config_path)
+		fmt.wprintf(
+			cmd.err,
+			"Config file does not exist at %s. Run 'envr init' first.\n",
+			config_path,
+			flush = false,
+		)
 		return
 	}

@@ -28,13 +33,13 @@ cmd_edit_config :: proc(cmd: ^Command) {

 	p, start_err := os.process_start(desc)
 	if start_err != nil {
-		fmt.printf("Error running editor: %v\n", start_err)
+		fmt.wprintf(cmd.err, "Error running editor: %v\n", start_err, flush = false)
 		return
 	}

 	state, wait_err := os.process_wait(p)
 	if wait_err != nil {
-		fmt.printf("Error waiting for editor: %v\n", wait_err)
+		fmt.wprintf(cmd.err, "Error waiting for editor: %v\n", wait_err, flush = false)
 		return
 	}
 	if state.exit_code != 0 {
--- a/cmd_init.odin
+++ b/cmd_init.odin
@@ -5,13 +5,15 @@ import "core:fmt"
 cmd_init :: proc(cmd: ^Command) {
 	force := has_flag(cmd, "force") || has_flag(cmd, "f")

-	fmt.println(cmd.config_path)
+	fmt.wprintln(cmd.out, cmd.config_path, flush = false)

 	_, cfg_exists := load_config(cmd.config_path)
 	if cfg_exists && !force {
-		fmt.println(
+		fmt.wprintln(
+			cmd.out,
 			`You have already initialized envr.
 Run again with the --force flag if you want to reinitialize.`,
+			flush = false,
 		)
 		return
 	}
@@ -22,15 +24,15 @@ Run again with the --force flag if you want to reinitialize.`,
 	}

 	if len(keys) == 0 {
-		fmt.println(`No ssh-ed25519 keys found in ~/.ssh
-Generate one with: ssh-keygen -t ed25519`)
+		fmt.wprintln(cmd.err, `No ssh-ed25519 keys found in ~/.ssh
+Generate one with: ssh-keygen -t ed25519`, flush = false)
 		return
 	}

 	selected, result := multi_select("Select SSH private keys:", keys[:])
 	defer delete(selected)
 	if result == .Cancel {
-		fmt.println("\x1b[2mCancelled.\x1b[0m")
+		fmt.wprintln(cmd.out, "\x1b[2mCancelled.\x1b[0m", flush = false)
 		return
 	}

@@ -42,7 +44,7 @@ Generate one with: ssh-keygen -t ed25519`)
 	}

 	if len(selected_paths) == 0 {
-		fmt.println("No SSH keys selected - Config not created")
+		fmt.wprintln(cmd.err, "No SSH keys selected - Config not created", flush = false)
 		return
 	}

@@ -51,9 +53,10 @@ Generate one with: ssh-keygen -t ed25519`)
 		return
 	}

-	fmt.printf(
+	fmt.wprintf(
+		cmd.out,
 		"Config initialized with %d SSH key(s). You are ready to use envr.\n",
 		len(selected_paths),
+		flush = false,
 	)
 }
-
--- a/cmd_list.odin
+++ b/cmd_list.odin
@@ -2,7 +2,6 @@ package main

 import "core:encoding/json"
 import "core:fmt"
-import "core:io"
 import "core:os"
 import "core:path/filepath"
 import "core:strings"
@@ -41,8 +40,7 @@ cmd_list :: proc(cmd: ^Command) {
 			append(&table_rows, row_slice)
 		}

-		w := io.to_writer(os.to_writer(os.stdout))
-		render_table(w, headers, table_rows[:])
+		render_table(cmd.out, headers, table_rows[:])
 	} else {
 		// TODO: Should we instead print full entries here?
 		entries: [dynamic]ListEntry
@@ -59,10 +57,10 @@ cmd_list :: proc(cmd: ^Command) {

 		data, marshal_err := json.marshal(entries[:], allocator = context.temp_allocator)
 		if marshal_err != nil {
-			fmt.printf("Error marshaling JSON: %v\n", marshal_err)
+			fmt.wprintf(cmd.err, "Error marshaling JSON: %v\n", marshal_err, flush = false)
 			return
 		}
-		fmt.println(string(data))
+		fmt.wprintln(cmd.out, string(data), flush = false)
 	}
 }

--- a/cmd_nushell_completion.odin
+++ b/cmd_nushell_completion.odin
@@ -5,7 +5,6 @@ import "core:fmt"
 COMPLETION_SCRIPT: string : string(#load("mod.nu"))

 cmd_nushell_completion :: proc(cmd: ^Command) {
-	// TODO: Use buffered writer?
-	fmt.print(COMPLETION_SCRIPT)
+	fmt.wprint(cmd.out, COMPLETION_SCRIPT, flush = false)
 }

--- a/cmd_remove.odin
+++ b/cmd_remove.odin
@@ -6,13 +6,13 @@ import "core:strings"

 cmd_remove :: proc(cmd: ^Command) {
 	if len(cmd.args) != 1 {
-		print_command_help("remove")
+		print_command_help(cmd)
 		return
 	}

 	path := cmd.args[0]
 	if len(strings.trim_space(path)) == 0 {
-		fmt.println("Error: No path provided")
+		fmt.wprintln(cmd.err, "Error: No path provided", flush = false)
 		return
 	}

@@ -23,7 +23,7 @@ cmd_remove :: proc(cmd: ^Command) {
 	} else {
 		resolved, abs_err := filepath.abs(path)
 		if abs_err != nil {
-			fmt.printf("Error getting absolute path: %v\n", abs_err)
+			fmt.wprintf(cmd.err, "Error getting absolute path: %v\n", abs_err, flush = false)
 			return
 		}
 		abs_path = resolved
@@ -39,6 +39,6 @@ cmd_remove :: proc(cmd: ^Command) {
 		return
 	}

-	fmt.printf("Removed %s from the database\n", abs_path)
+	fmt.wprintf(cmd.out, "Removed %s from the database\n", abs_path, flush = false)
 }

--- a/cmd_restore.odin
+++ b/cmd_restore.odin
@@ -7,13 +7,13 @@ import "core:strings"

 cmd_restore :: proc(cmd: ^Command) {
 	if len(cmd.args) != 1 {
-		print_command_help("restore")
+		print_command_help(cmd)
 		return
 	}

 	path := cmd.args[0]
 	if len(strings.trim_space(path)) == 0 {
-		fmt.println("Error: No path provided")
+		fmt.wprintln(cmd.err, "Error: No path provided", flush = false)
 		return
 	}

@@ -24,7 +24,7 @@ cmd_restore :: proc(cmd: ^Command) {
 	} else {
 		resolved, abs_err := filepath.abs(path)
 		if abs_err != nil {
-			fmt.printf("Error getting absolute path: %v\n", abs_err)
+			fmt.wprintf(cmd.err, "Error getting absolute path: %v\n", abs_err, flush = false)
 			return
 		}
 		abs_path = resolved
@@ -46,10 +46,10 @@ cmd_restore :: proc(cmd: ^Command) {

 	write_err := os.write_entire_file(file.Path, file.contents)
 	if write_err != nil {
-		fmt.printf("Error writing file: %v\n", write_err)
+		fmt.wprintf(cmd.err, "Error writing file: %v\n", write_err, flush = false)
 		return
 	}

-	fmt.printf("Restored %s\n", file.Path)
+	fmt.wprintf(cmd.out, "Restored %s\n", file.Path, flush = false)
 }

--- a/cmd_scan.odin
+++ b/cmd_scan.odin
@@ -8,8 +8,10 @@ import "core:terminal"
 cmd_scan :: proc(cmd: ^Command) {
 	feats := check_features()
 	if cant_scan(feats) {
-		fmt.println(
+		fmt.wprintln(
+			cmd.err,
 			"Error: please install fd to use the scan command (https://github.com/sharkdp/fd)",
+			flush = false,
 		)
 		return
 	}
@@ -22,7 +24,11 @@ cmd_scan :: proc(cmd: ^Command) {

 	search_dirs := search_paths(db.cfg)
 	if len(search_dirs) == 0 {
-		fmt.println("No search paths configured. Please run `envr init -f` or edit your config.")
+		fmt.wprintln(
+			cmd.err,
+			"No search paths configured. Please run `envr init -f` or edit your config.",
+			flush = false,
+		)
 		return
 	}

@@ -31,7 +37,7 @@ cmd_scan :: proc(cmd: ^Command) {
 	for dir in search_dirs {
 		found, scan_ok := scan_path(dir, db.cfg)
 		if !scan_ok {
-			fmt.printf("Error scanning %s\n", dir)
+			fmt.wprintf(cmd.err, "Error scanning %s\n", dir, flush = false)
 			continue
 		}
 		for f in found {
@@ -47,24 +53,29 @@ cmd_scan :: proc(cmd: ^Command) {
 	files := find_unbacked(all_files[:], db_files[:])

 	if len(files) == 0 {
-		fmt.println("No .env files found to add.")
+		fmt.wprintln(cmd.out, "No .env files found to add.", flush = false)
 		return
 	}

 	if !terminal.is_terminal(os.stdout) {
 		output, marshal_err := json.marshal(files[:])
 		if marshal_err != nil {
-			fmt.printf("Error marshaling files to JSON: %v\n", marshal_err)
+			fmt.wprintf(
+				cmd.err,
+				"Error marshaling files to JSON: %v\n",
+				marshal_err,
+				flush = false,
+			)
 			return
 		}
-		fmt.println(string(output))
+		fmt.wprintln(cmd.out, string(output), flush = false)
 		return
 	}

 	selected, result := multi_select("Select .env files to backup:", files[:])
 	defer delete(selected)
 	if result == .Cancel {
-		fmt.println("\x1b[2mCancelled.\x1b[0m")
+		fmt.wprintln(cmd.out, "\x1b[2mCancelled.\x1b[0m", flush = false)
 		return
 	}

@@ -75,20 +86,25 @@ cmd_scan :: proc(cmd: ^Command) {
 		}
 		env_file, ok := new_env_file(files[i])
 		if !ok {
-			fmt.printf("Error reading %s\n", files[i])
+			fmt.wprintf(cmd.err, "Error reading %s\n", files[i], flush = false)
 			continue
 		}
 		if !db_insert(&db, env_file) {
-			fmt.printf("Error adding %s\n", files[i])
+			fmt.wprintf(cmd.err, "Error adding %s\n", files[i], flush = false)
 			continue
 		}
 		added_count += 1
 	}

 	if added_count > 0 {
-		fmt.printf("\x1b[1;32mSuccessfully added %d file(s) to backup.\x1b[0m\n", added_count)
+		fmt.wprintf(
+			cmd.out,
+			"\x1b[1;32mSuccessfully added %d file(s) to backup.\x1b[0m\n",
+			added_count,
+			flush = false,
+		)
 	} else {
-		fmt.println("\x1b[2mNo files were added.\x1b[0m")
+		fmt.wprintln(cmd.out, "\x1b[2mNo files were added.\x1b[0m", flush = false)
 	}
 }

--- a/cmd_sync.odin
+++ b/cmd_sync.odin
@@ -2,7 +2,6 @@ package main

 import "core:encoding/json"
 import "core:fmt"
-import "core:io"
 import "core:os"
 import "core:strings"
 import "core:terminal"
@@ -84,15 +83,14 @@ cmd_sync :: proc(cmd: ^Command) {
 			append(&table_rows, row_slice)
 		}

-		w := io.to_writer(os.to_writer(os.stdout))
-		render_table(w, headers, table_rows[:])
+		render_table(cmd.out, headers, table_rows[:])
 	} else {
 		data, marshal_err := json.marshal(results[:])
 		if marshal_err != nil {
-			fmt.printf("Error marshaling JSON: %v\n", marshal_err)
+			fmt.wprintf(cmd.err, "Error marshaling JSON: %v\n", marshal_err, flush = false)
 			return
 		}
-		fmt.println(string(data))
+		fmt.wprintln(cmd.out, string(data), flush = false)
 	}
 }

--- a/cmd_version.odin
+++ b/cmd_version.odin
@@ -5,6 +5,6 @@ import "core:fmt"
 VERSION :: #load("version.txt", string)

 cmd_version :: proc(cmd: ^Command) {
-	fmt.println(VERSION)
+	fmt.wprintln(cmd.out, VERSION, flush = false)
 }

--- a/config.odin
+++ b/config.odin
@@ -23,8 +23,8 @@ Config :: struct {
 	config_path: string `json:"-"`,
 }

-default_config_path :: proc(home: string) -> string {
-	path, err := filepath.join([]string{home, ".envr", "config.json"})
+default_config_path :: proc(home: string, allocator := context.allocator) -> string {
+	path, err := filepath.join([]string{home, ".envr", "config.json"}, allocator)
 	if err != nil {
 		panic("Ran out of memory when building config path")
 	}
@@ -37,6 +37,7 @@ load_config :: proc(config_path: string) -> (Config, bool) {
 		fmt.println("No config file found. Please run `envr init` to generate one.")
 		return Config{}, false
 	}
+	defer delete(data)

 	cfg: Config
 	// TODO: use json 5
@@ -50,9 +51,23 @@ load_config :: proc(config_path: string) -> (Config, bool) {
 	return cfg, true
 }

-delete_config :: proc(cfg: Config) {
+delete_config :: proc(cfg: ^Config) {
+	for key in cfg.Keys {
+		delete(key.Private)
+		delete(key.Public)
+	}
 	delete(cfg.Keys)
+
+	delete(cfg.ScanConfig.Matcher)
+
+	for exclude in cfg.ScanConfig.Exclude {
+		delete(exclude)
+	}
 	delete(cfg.ScanConfig.Exclude)
+
+	for include in cfg.ScanConfig.Include {
+		delete(include)
+	}
 	delete(cfg.ScanConfig.Include)
 }

@@ -118,21 +133,22 @@ new_config :: proc(
 	keys := make([dynamic]SshKeyPair, 0, len(private_key_paths))
 	for priv in private_key_paths {
 		// TODO: Is this bad?
-		pub, _ := strings.concatenate([]string{priv, ".pub"}, context.temp_allocator)
-		append(&keys, SshKeyPair{Private = priv, Public = pub})
+		priv_key := strings.clone(priv)
+		pub, _ := strings.concatenate([]string{priv_key, ".pub"})
+		append(&keys, SshKeyPair{Private = priv_key, Public = pub})
 	}

 	exclude := make([dynamic]string, 0, 4)
-	append(&exclude, "*\\.envrc")
-	append(&exclude, "\\.local/")
-	append(&exclude, "node_modules")
-	append(&exclude, "vendor")
+	append(&exclude, strings.clone("*\\.envrc"))
+	append(&exclude, strings.clone("\\.local/"))
+	append(&exclude, strings.clone("node_modules"))
+	append(&exclude, strings.clone("vendor"))

 	include := make([dynamic]string, 0, 1)
-	append(&include, "~")
+	append(&include, strings.clone("~"))

 	scan_cfg := ScanConfig {
-		Matcher = "\\.env",
+		Matcher = strings.clone("\\.env"),
 		Exclude = exclude,
 		Include = include,
 	}
@@ -167,6 +183,7 @@ save_config :: proc(cfg: Config, force: bool = false) -> bool {
 		fmt.printf("Error marshaling config: %v\n", marshal_err)
 		return false
 	}
+	defer delete(data)

 	write_err := os.write_entire_file(cfg.config_path, data)
 	if write_err != nil {
@@ -178,15 +195,18 @@ save_config :: proc(cfg: Config, force: bool = false) -> bool {
 }

 search_paths :: proc(cfg: Config) -> (paths: [dynamic]string) {
-	home, _ := os.user_home_dir(context.allocator)
+	// TODO: Is this okay?
+	// TODO: handle error
+	home, _ := os.user_home_dir(context.temp_allocator)

 	for include in cfg.ScanConfig.Include {
+		// TODO: Do we need to manually expand ~/ in odin?
 		expanded, _ := strings.replace(include, "~", home, 1)
-		cloned, _ := strings.clone(expanded)
-		if filepath.is_abs(cloned) {
-			append(&paths, cloned)
+		if filepath.is_abs(expanded) {
+			append(&paths, expanded)
 		} else {
-			resolved, err := filepath.abs(cloned)
+			defer delete(expanded)
+			resolved, err := filepath.abs(expanded)
 			if err == nil {
 				append(&paths, resolved)
 			}
--- a/config_test.odin
+++ b/config_test.odin
@@ -13,7 +13,7 @@ home_mutex: sync.Mutex
 test_new_config_single_key :: proc(t: ^testing.T) {
 	paths := []string{"/home/user/.ssh/id_ed25519"}
 	cfg := new_config(paths)
-	defer delete_config(cfg)
+	defer delete_config(&cfg)

 	testing.expect(t, len(cfg.Keys) == 1, "should have 1 key")
 	testing.expect(t, cfg.Keys[0].Private == "/home/user/.ssh/id_ed25519", "Private path mismatch")
@@ -28,7 +28,7 @@ test_new_config_single_key :: proc(t: ^testing.T) {
 test_new_config_multiple_keys :: proc(t: ^testing.T) {
 	paths := []string{"/home/user/.ssh/id_ed25519", "/home/user/.ssh/id_rsa"}
 	cfg := new_config(paths)
-	defer delete_config(cfg)
+	defer delete_config(&cfg)

 	testing.expect(t, len(cfg.Keys) == 2, "should have 2 keys")
 	testing.expect(t, cfg.Keys[0].Private == "/home/user/.ssh/id_ed25519")
@@ -39,7 +39,7 @@ test_new_config_multiple_keys :: proc(t: ^testing.T) {
 test_new_config_empty_keys :: proc(t: ^testing.T) {
 	paths: []string
 	cfg := new_config(paths)
-	defer delete_config(cfg)
+	defer delete_config(&cfg)

 	testing.expect(t, len(cfg.Keys) == 0, "should have 0 keys")
 }
@@ -48,7 +48,7 @@ test_new_config_empty_keys :: proc(t: ^testing.T) {
 test_new_config_scan_defaults :: proc(t: ^testing.T) {
 	paths := []string{"/home/user/.ssh/id_ed25519"}
 	cfg := new_config(paths)
-	defer delete_config(cfg)
+	defer delete_config(&cfg)

 	testing.expect(t, cfg.ScanConfig.Matcher == "\\.env", "matcher should be \\.env")
 	testing.expect(t, len(cfg.ScanConfig.Exclude) == 4, "should have 4 exclude patterns")
@@ -60,7 +60,7 @@ test_new_config_scan_defaults :: proc(t: ^testing.T) {
 test_new_config_exclude_patterns :: proc(t: ^testing.T) {
 	paths := []string{"/home/user/.ssh/id_ed25519"}
 	cfg := new_config(paths)
-	defer delete_config(cfg)
+	defer delete_config(&cfg)

 	expected := []string{"*\\.envrc", "\\.local/", "node_modules", "vendor"}
 	for i in 0 ..< len(expected) {
@@ -78,14 +78,14 @@ test_save_load_config_roundtrip :: proc(t: ^testing.T) {
 	testing.expect(t, err == nil, "cfgPath should build successfully")

 	cfg := new_config([]string{"/home/user/.ssh/id_ed25519"}, cfgPath)
-	defer delete_config(cfg)
+	defer delete_config(&cfg)

 	testing.expect(t, save_config(cfg, force = true), "save should succeed")

 	loaded, ok := load_config(cfg.config_path)
 	testing.expect(t, ok, "load should succeed")
 	if !ok do return
-	defer delete_config(loaded)
+	defer delete_config(&loaded)

 	testing.expect(t, len(loaded.Keys) == 1, "should have 1 key")
 	testing.expect(t, loaded.Keys[0].Private == "/home/user/.ssh/id_ed25519")
@@ -112,11 +112,11 @@ test_save_config_no_clobber :: proc(t: ^testing.T) {
 	testing.expect(t, err == nil, "cfgPath should build successfully")

 	cfg := new_config([]string{"/home/user/.ssh/key1"}, cfgPath)
-	defer delete_config(cfg)
+	defer delete_config(&cfg)
 	testing.expect(t, save_config(cfg, force = true), "first save should succeed")

 	cfg2 := new_config([]string{"/home/user/.ssh/key2"}, cfgPath)
-	defer delete_config(cfg2)
+	defer delete_config(&cfg2)
 	testing.expect(t, !save_config(cfg2), "second save without force should fail")
 }

@@ -130,17 +130,17 @@ test_save_config_force_overwrites :: proc(t: ^testing.T) {
 	testing.expect(t, err == nil, "cfgPath should build successfully")

 	cfg := new_config([]string{"/home/user/.ssh/key1"}, cfgPath)
-	defer delete_config(cfg)
+	defer delete_config(&cfg)
 	testing.expect(t, save_config(cfg, force = true), "first save should succeed")

 	cfg2 := new_config([]string{"/home/user/.ssh/key2"}, cfgPath)
-	defer delete_config(cfg2)
+	defer delete_config(&cfg2)
 	testing.expect(t, save_config(cfg2, force = true), "force save should overwrite")

 	loaded, ok := load_config(cfgPath)
 	testing.expect(t, ok, "load should succeed")
 	if !ok do return
-	defer delete_config(loaded)
+	defer delete_config(&loaded)

 	testing.expect(t, len(loaded.Keys) == 1, "should have 1 key")
 	testing.expect(
@@ -165,6 +165,7 @@ test_envr_dir :: proc(t: ^testing.T) {
@(test)
 test_data_encrypted_path :: proc(t: ^testing.T) {
 	p := data_encrypted_path("/tmp/envr-fake-home-datapath/config.json")
+	defer delete(p)
 	testing.expectf(t, strings.has_suffix(p, "data.envr"), "should end with data.envr, got %s", p)
 	testing.expectf(t, strings.contains(p, ".envr"), "should contain .envr dir, got %s", p)
 }
@@ -191,6 +192,9 @@ test_search_paths_expands_tilde :: proc(t: ^testing.T) {

 	paths := search_paths(cfg)
 	defer delete(paths)
+	for path in paths {
+		defer delete(path)
+	}

 	testing.expect(t, len(paths) == 1, "should have 1 path")
 	if len(paths) > 0 {
--- a/db.odin
+++ b/db.odin
@@ -41,10 +41,21 @@ EnvFile :: struct {
 	contents: string,
 }

+delete_envfile :: proc(f: ^EnvFile) {
+	delete(f.Path)
+	for &remote in f.Remotes {
+		delete(remote)
+	}
+	delete(f.Remotes)
+	delete(f.Sha256)
+	delete(f.contents)
+}
+
 make_temp_path :: proc() -> string {
 	ts := time.time_to_unix(time.now())
 	b: strings.Builder
 	strings.builder_init(&b)
+	defer strings.builder_destroy(&b)
 	fmt.sbprintf(&b, "/tmp/envr-%d-%d.db", os.get_pid(), ts)
 	return strings.to_string(b)
 }
@@ -126,6 +137,13 @@ db_close :: proc(d: ^Db) {
 	sqlite.db_close(d.db)
 }

+// Caller is responsible for calling:
+// ```odin
+// delete(results)
+// for &result in results {
+// 	delete(&result)
+// }
+// ```
 db_list :: proc(d: ^Db, allocator := context.allocator) -> (results: [dynamic]EnvFile, ok: bool) {
 	stmt: ^rawptr
 	rc := sqlite.prepare_v2(
@@ -139,6 +157,7 @@ db_list :: proc(d: ^Db, allocator := context.allocator) -> (results: [dynamic]En
 		fmt.printf("Error preparing query: %s\n", sqlite.db_errmsg(d.db))
 		return
 	}
+	defer sqlite.finalize(stmt)

 	for {
 		rc = sqlite.step(stmt)
@@ -147,14 +166,13 @@ db_list :: proc(d: ^Db, allocator := context.allocator) -> (results: [dynamic]En
 		}
 		if rc != sqlite.ROW {
 			fmt.printf("Error stepping query: %s\n", sqlite.db_errmsg(d.db))
-			sqlite.finalize(stmt)
 			return
 		}

 		remotes_json := string(sqlite.column_text(stmt, 1))
-		remotes := make([dynamic]string, strings.count(remotes_json, ",") + 1, allocator)
+		remotes: [dynamic]string = ---
 		if len(remotes_json) > 0 {
-			json.unmarshal_string(remotes_json, &remotes)
+			json.unmarshal_string(remotes_json, &remotes, allocator = allocator)
 		}
 		path := clone_cstring(sqlite.column_text(stmt, 0), allocator)

@@ -170,7 +188,6 @@ db_list :: proc(d: ^Db, allocator := context.allocator) -> (results: [dynamic]En
 		)
 	}

-	sqlite.finalize(stmt)
 	ok = true
 	return
 }
@@ -178,6 +195,7 @@ db_list :: proc(d: ^Db, allocator := context.allocator) -> (results: [dynamic]En
 db_vacuum_to_file :: proc(db: ^rawptr, path: string) -> bool {
 	b: strings.Builder
 	strings.builder_init(&b)
+	defer strings.builder_destroy(&b)
 	fmt.sbprintf(&b, "VACUUM INTO '%s'", path)
 	rc := sqlite.db_exec(db, to_cstring(&b), nil, nil, nil)
 	if rc != sqlite.OK {
@@ -220,10 +238,10 @@ db_restore_from_encrypted :: proc(db: ^rawptr, cfg: Config) -> bool {
 db_attach_and_copy :: proc(mem_db: ^rawptr, src_path: string) -> bool {
 	b: strings.Builder
 	strings.builder_init(&b)
+	defer strings.builder_destroy(&b)
 	fmt.sbprintf(&b, "ATTACH DATABASE '%s' AS source", src_path)
-	attach_sql := strings.to_string(b)

-	rc := sqlite.db_exec(mem_db, to_cstring(attach_sql), nil, nil, nil)
+	rc := sqlite.db_exec(mem_db, to_cstring(&b), nil, nil, nil)
 	if rc != sqlite.OK {
 		fmt.printf("Error attaching database: %s\n", sqlite.db_errmsg(mem_db))
 		return false
@@ -252,6 +270,7 @@ get_git_remotes :: proc(dir: string) -> [dynamic]string {

 	b: strings.Builder
 	strings.builder_init(&b)
+	defer strings.builder_destroy(&b)
 	fmt.sbprintf(&b, "%s-git-remotes", make_temp_path())
 	tmp_path := strings.to_string(b)
 	tmp_file, tmp_err := os.open(tmp_path, os.O_CREATE | os.O_WRONLY | os.O_TRUNC)
@@ -281,6 +300,7 @@ get_git_remotes :: proc(dir: string) -> [dynamic]string {
 	}

 	data, read_err := os.read_entire_file_from_path(tmp_path, context.allocator)
+	defer delete(data)
 	os.remove(tmp_path)
 	if read_err != nil {
 		return remotes
@@ -313,27 +333,24 @@ new_env_file :: proc(path: string) -> (EnvFile, bool) {
 		fmt.printf("Error getting absolute path: %v\n", abs_err)
 		return EnvFile{}, false
 	}
-	cloned_path, err := strings.clone(abs_path)
-	if err != nil {
-		panic("Ran out of memory")
-	}

-	dir := filepath.dir(cloned_path)
+	dir := filepath.dir(abs_path)

 	remotes := get_git_remotes(dir)

-	data, read_err := os.read_entire_file_from_path(cloned_path, context.allocator)
+	data, read_err := os.read_entire_file_from_path(abs_path, context.allocator)
+	defer delete(data)
 	if read_err != nil {
-		fmt.printf("Error reading file %s: %v\n", cloned_path, read_err)
+		fmt.printf("Error reading file %s: %v\n", abs_path, read_err)
 		return EnvFile{}, false
 	}

-	digest := hash.hash_bytes(hash.Algorithm.SHA256, data)
+	digest := hash.hash_bytes(hash.Algorithm.SHA256, data, context.temp_allocator)
 	// TODO: Handle error
 	hex_bytes, _ := hex.encode(digest)

 	return EnvFile {
-			Path = cloned_path,
+			Path = abs_path,
 			Dir = dir,
 			Remotes = remotes,
 			Sha256 = string(hex_bytes),
@@ -348,6 +365,7 @@ db_insert :: proc(d: ^Db, file: EnvFile) -> bool {
 		fmt.printf("Error marshaling remotes: %v\n", marshal_err)
 		return false
 	}
+	defer delete(remotes_json)

 	sql: cstring =
 		"INSERT OR REPLACE INTO " +
@@ -411,7 +429,7 @@ db_fetch :: proc(d: ^Db, path: string, allocator := context.allocator) -> (EnvFi
 	}

 	remotes_json := string(sqlite.column_text(stmt, 1))
-	remotes := make([dynamic]string, strings.count(remotes_json, ",") + 1, allocator)
+	remotes: [dynamic]string = ---
 	if len(remotes_json) > 0 {
 		json.unmarshal_string(remotes_json, &remotes, allocator = allocator)
 	}
@@ -474,6 +492,7 @@ clone_cstring :: proc(c: cstring, allocator := context.allocator) -> string {
 	str, err := strings.clone_from_cstring(c, allocator)
 	if err != nil {
 		fmt.printf("Failed to convert string to cstring: %v\n", err)
+		delete(str)
 		panic("Allocation Exception")
 	}

@@ -526,24 +545,11 @@ find_moved_dirs :: proc(d: ^Db, f: ^EnvFile) -> ([dynamic]string, bool) {
 	return moved, true
 }

-env_file_backup :: proc(f: ^EnvFile) -> bool {
-	data, read_err := os.read_entire_file_from_path(f.Path, context.allocator)
-	if read_err != nil {
-		fmt.printf("Error reading file %s: %v\n", f.Path, read_err)
-		return false
-	}
-
-	f.contents = string(data)
-	digest := hash.hash_bytes(hash.Algorithm.SHA256, data)
-	hex_bytes, alloc_err := hex.encode(digest)
-	if alloc_err != nil {
-		fmt.printf("Error generating hash for file %s: %v\n", f.Path, alloc_err)
-		return false
-	}
-	f.Sha256 = string(hex_bytes)
-	return true
+db_sync :: proc(d: ^Db, f: ^EnvFile) -> (SyncFlag, string) {
+	return env_file_sync(f, .TrustFilesystem, d)
 }

+// If SyncFlag is .BackedUp, Caller is responsible for calling delete on f.contents and f.Sha256
 env_file_sync :: proc(f: ^EnvFile, dir: SyncDirection, d: ^Db) -> (SyncFlag, string) {
 	result: SyncFlag = {}

@@ -615,7 +621,24 @@ env_file_sync :: proc(f: ^EnvFile, dir: SyncDirection, d: ^Db) -> (SyncFlag, str
 	return result, ""
 }

-db_sync :: proc(d: ^Db, f: ^EnvFile) -> (SyncFlag, string) {
-	return env_file_sync(f, .TrustFilesystem, d)
+// Loads the contents of the the file at f.Path into f.contents
+//
+// Caller is responsible for calling delete on f.contents and f.Sha256
+env_file_backup :: proc(f: ^EnvFile) -> bool {
+	data, read_err := os.read_entire_file_from_path(f.Path, context.allocator)
+	if read_err != nil {
+		fmt.printf("Error reading file %s: %v\n", f.Path, read_err)
+		return false
+	}
+
+	f.contents = string(data)
+	digest := hash.hash_bytes(hash.Algorithm.SHA256, data, context.temp_allocator)
+	hex_bytes, alloc_err := hex.encode(digest)
+	if alloc_err != nil {
+		fmt.printf("Error generating hash for file %s: %v\n", f.Path, alloc_err)
+		return false
+	}
+	f.Sha256 = string(hex_bytes)
+	return true
 }

--- a/db_integration_test.odin
+++ b/db_integration_test.odin
@@ -180,16 +180,16 @@ test_decrypt_then_attach_sqlite :: proc(t: ^testing.T) {
 	}
 	defer sqlite.db_close(mem_db)

-	create_sql := "CREATE TABLE IF NOT EXISTS envr_env_files (path TEXT PRIMARY KEY NOT NULL, remotes TEXT, sha256 TEXT NOT NULL, contents TEXT NOT NULL)"
-	rc = sqlite.db_exec(mem_db, string_to_cstring(create_sql), nil, nil, nil)
+	create_sql: cstring = "CREATE TABLE IF NOT EXISTS envr_env_files (path TEXT PRIMARY KEY NOT NULL, remotes TEXT, sha256 TEXT NOT NULL, contents TEXT NOT NULL)"
+	rc = sqlite.db_exec(mem_db, create_sql, nil, nil, nil)
 	testing.expect(t, rc == sqlite.OK, "failed to create table")

 	attach_ok := db_attach_and_copy(mem_db, tmp_db_path)
 	testing.expect(t, attach_ok, "failed to attach and copy")

-	sql := "SELECT path FROM envr_env_files"
+	sql: cstring = "SELECT path FROM envr_env_files"
 	stmt: ^rawptr
-	rc = sqlite.prepare_v2(mem_db, string_to_cstring(sql), -1, &stmt, nil)
+	rc = sqlite.prepare_v2(mem_db, sql, -1, &stmt, nil)
 	testing.expect(t, rc == sqlite.OK, "prepare failed")
 	if rc != sqlite.OK {
 		return
@@ -207,9 +207,7 @@ test_decrypt_then_attach_sqlite :: proc(t: ^testing.T) {
@(test)
 test_full_db_cycle :: proc(t: ^testing.T) {
 	cfg := fixture_config()
-	defer {
-		delete(cfg.Keys)
-	}
+	defer delete(cfg.Keys)

 	db_path := fixture_db_path()
 	original_data, read_err := os.read_entire_file_from_path(db_path, context.allocator)
@@ -230,6 +228,7 @@ test_full_db_cycle :: proc(t: ^testing.T) {
 	os.mkdir_all(envr_dir_path)

 	data_path, _ := filepath.join([]string{envr_dir_path, "data.envr"})
+	defer delete(data_path)
 	write_err := os.write_entire_file(data_path, encrypted)
 	testing.expectf(t, write_err == nil, "failed to write data.envr: %v", write_err)
 	if write_err != nil {
--- a/db_test.odin
+++ b/db_test.odin
@@ -15,8 +15,8 @@ make_test_db :: proc() -> (Db, bool) {
 		return Db{}, false
 	}

-	create_sql := "CREATE TABLE IF NOT EXISTS envr_env_files (path TEXT PRIMARY KEY NOT NULL, remotes TEXT, sha256 TEXT NOT NULL, contents TEXT NOT NULL)"
-	rc = sqlite.db_exec(db, string_to_cstring(create_sql), nil, nil, nil)
+	create_sql: cstring = "CREATE TABLE IF NOT EXISTS envr_env_files (path TEXT PRIMARY KEY NOT NULL, remotes TEXT, sha256 TEXT NOT NULL, contents TEXT NOT NULL)"
+	rc = sqlite.db_exec(db, create_sql, nil, nil, nil)
 	if rc != sqlite.OK {
 		sqlite.db_close(db)
 		return Db{}, false
@@ -56,9 +56,9 @@ test_db_insert_and_fetch :: proc(t: ^testing.T) {
 	testing.expect(t, db_insert(&d, f), "insert should succeed")

 	fetched, fetch_ok := db_fetch(&d, "/project/.env")
+	defer delete_envfile(&fetched)
 	testing.expect(t, fetch_ok, "fetch should succeed")
 	if !fetch_ok do return
-	defer delete(fetched.Remotes)

 	testing.expect_value(t, fetched.Path, path)
 	testing.expect_value(t, fetched.Sha256, sha)
@@ -97,16 +97,19 @@ test_db_insert_or_replace :: proc(t: ^testing.T) {
 	testing.expect(t, list_ok, "list should succeed")
 	if !list_ok do return
 	defer delete(results)
+	for &result in results {
+		defer delete_envfile(&result)
+	}

 	testing.expect(t, len(results) == 1, "should have 1 row, not 2")

 	fetched, fetch_ok := db_fetch(&d, "/project/.env")
 	testing.expect(t, fetch_ok, "fetch should succeed")
 	if !fetch_ok do return
-	defer delete(fetched.Remotes)
+	defer delete_envfile(&fetched)

-	testing.expect(t, fetched.contents == "KEY=new", "contents should be updated")
-	testing.expect(t, fetched.Sha256 == "sha2", "sha should be updated")
+	testing.expect_value(t, fetched.contents, "KEY=new")
+	testing.expect_value(t, fetched.Sha256, "sha2")
 }

@(test)
@@ -144,11 +147,10 @@ test_db_list_multiple :: proc(t: ^testing.T) {
 	defer sqlite.db_close(d.db)

 	f1 := make_test_env_file("/proj1/.env", "sha1", "A=1", []string{"git@github.com:a/repo.git"})
-	f2 := make_test_env_file("/proj2/.env", "sha2", "B=2", []string{"git@github.com:b/repo.git"})
-	f3 := make_test_env_file("/proj3/.env", "sha3", "C=3")
 	defer delete(f1.Remotes)
+	f2 := make_test_env_file("/proj2/.env", "sha2", "B=2", []string{"git@github.com:b/repo.git"})
 	defer delete(f2.Remotes)
-	defer delete(f3.Remotes)
+	f3 := make_test_env_file("/proj3/.env", "sha3", "C=3")

 	db_insert(&d, f1)
 	db_insert(&d, f2)
@@ -158,8 +160,13 @@ test_db_list_multiple :: proc(t: ^testing.T) {
 	testing.expect(t, list_ok, "list should succeed")
 	if !list_ok do return
 	defer delete(results)
+	defer {
+		for &result in results {
+			delete_envfile(&result)
+		}
+	}

-	testing.expect(t, len(results) == 3, "should have 3 rows")
+	testing.expect_value(t, len(results), 3)
 }

@(test)
@@ -223,13 +230,12 @@ test_db_vacuum_to_file :: proc(t: ^testing.T) {

 	testing.expect(t, db_vacuum_to_file(d.db, vacuum_path), "vacuum should succeed")

-	_, stat_err := os.stat(vacuum_path, context.allocator)
+	info, stat_err := os.stat(vacuum_path, context.allocator)
+	defer os.file_info_delete(info, context.allocator)
 	testing.expect(t, stat_err == nil, "vacuumed file should exist")
-	if stat_err != nil do return

 	data, read_err := os.read_entire_file_from_path(vacuum_path, context.allocator)
 	testing.expect(t, read_err == nil, "should read vacuumed file")
-	if read_err != nil do return
 	defer delete(data)

 	testing.expect(t, len(data) > 0, "vacuumed file should be non-empty")
@@ -341,6 +347,8 @@ test_new_env_file :: proc(t: ^testing.T) {
 	testing.expect(t, ok, "new_env_file should succeed")
 	if !ok do return
 	defer delete(file.Remotes)
+	defer delete(file.Sha256)
+	defer delete(file.Path)

 	testing.expect(t, filepath.is_abs(file.Path), "path should be absolute")
 	testing.expect(t, strings.has_suffix(file.Path, "/.env"), "path should end with /.env")
@@ -367,9 +375,11 @@ test_env_file_backup :: proc(t: ^testing.T) {
 	f := EnvFile {
 		Path = env_path,
 	}
+	defer delete(f.contents)
+	defer delete(f.Sha256)
 	testing.expect(t, env_file_backup(&f), "backup should succeed")
-	testing.expect(t, f.contents == "KEY=12345\n", "contents should be populated")
-	testing.expect(t, len(f.Sha256) == 64, "sha256 should be 64 hex chars")
+	testing.expect_value(t, f.contents, "KEY=12345\n")
+	testing.expect_value(t, len(f.Sha256), 64)
 }

@(test)
@@ -387,11 +397,11 @@ test_update_dir :: proc(t: ^testing.T) {
 		Dir     = "/old/project",
 		Remotes = make([dynamic]string, 0),
 	}
-	defer delete(f.Remotes)
+	defer delete_envfile(&f)

 	update_dir(&f, "/new/location")

-	testing.expect(t, f.Dir == "/new/location", "dir should be updated")
-	testing.expect(t, f.Path == "/new/location/.env", "path should be updated")
+	testing.expect_value(t, f.Dir, "/new/location")
+	testing.expect_value(t, f.Path, "/new/location/.env")
 }

--- a/main.odin
+++ b/main.odin
@@ -1,10 +1,12 @@
 package main

+import "core:bufio"
 import "core:fmt"
 import "core:os"

 main :: proc() {
-	cmd, ok := parse_args(os.args)
+	cmd, ok := parse_args(os.args, os.to_writer(os.stdout), os.to_writer(os.stderr))
+	defer bufio.writer_flush(cmd.out_buf)
 	if !ok {
 		return
 	}
@@ -35,10 +37,9 @@ main :: proc() {
 	case "nushell-completion":
 		cmd_nushell_completion(&cmd)
 	case:
-		fmt.printf("Unknown command: %s\n", cmd.name)
-		print_usage()
+		fmt.wprintf(cmd.err, "Unknown command: %s\n", cmd.name)
+		write_usage(cmd.out)
 		os.exit(1)
 	}
 }

-
--- a/main.odin.bak
+++ b/main.odin.bak
@@ -1,44 +0,0 @@
-package main
-
-import "core:fmt"
-import "core:os"
-
-main :: proc() {
-	cmd, ok := parse_args()
-	if !ok {
-		return
-	}
-
-	switch cmd.name {
-	case "init":
-		cmd_init(&cmd)
-	case "version":
-		cmd_version(&cmd)
-	case "deps":
-		cmd_deps(&cmd)
-	case "list":
-		cmd_list(&cmd)
-	case "backup", "add":
-		cmd_backup(&cmd)
-	case "remove":
-		cmd_remove(&cmd)
-	case "restore":
-		cmd_restore(&cmd)
-	case "edit-config":
-		cmd_edit_config(&cmd)
-	case "check":
-		cmd_check(&cmd)
-	case "scan":
-		cmd_scan(&cmd)
-	case "sync":
-		cmd_sync(&cmd)
-	case "nushell-completion":
-		cmd_nushell_completion(&cmd)
-	case:
-		fmt.printf("Unknown command: %s\n", cmd.name)
-		print_usage()
-		os.exit(1)
-	}
-}
-
-
--- a/table_test.odin
+++ b/table_test.odin
@@ -116,12 +116,22 @@ test_render_table_normal :: proc(t: ^testing.T) {

 	output := strings.to_string(b)

-	testing.expect(t, strings.contains(output, "Name"), "header 'Name' missing from output")
-	testing.expect(t, strings.contains(output, "Path"), "header 'Path' missing from output")
-	testing.expect(t, strings.contains(output, "foo"), "cell 'foo' missing from output")
-	testing.expect(t, strings.contains(output, "/home/user/.env"), "cell '/home/user/.env' missing from output")
-	testing.expect(t, strings.contains(output, "bar"), "cell 'bar' missing from output")
-	testing.expect(t, strings.contains(output, "/home/user/project/.env"), "cell '/home/user/project/.env' missing")
+	expected := `┌──────┬─────────────────────────┐
+│ Name │ Path                    │
+├──────┼─────────────────────────┤
+│ foo  │ /home/user/.env         │
+│ bar  │ /home/user/project/.env │
+└──────┴─────────────────────────┘
+`
+	testing.expect(
+		t,
+		output == expected,
+		fmt.tprintf(
+			"table output mismatch\n--- expected ---\n%s\n--- got ---\n%s\n",
+			expected,
+			output,
+		),
+	)
 }

@(test)
@@ -138,7 +148,20 @@ test_render_table_empty :: proc(t: ^testing.T) {

 	output := strings.to_string(b)

-	testing.expect(t, strings.contains(output, "Name"), "header 'Name' missing from output")
+	expected := `┌──────┐
+│ Name │
+├──────┤
+└──────┘
+`
+	testing.expect(
+		t,
+		output == expected,
+		fmt.tprintf(
+			"table output mismatch\n--- expected ---\n%s\n--- got ---\n%s\n",
+			expected,
+			output,
+		),
+	)
 }

@(test)
@@ -155,7 +178,21 @@ test_render_table_unicode :: proc(t: ^testing.T) {

 	output := strings.to_string(b)

-	testing.expect(t, strings.contains(output, "Available"), "unicode cell content missing")
-	testing.expect(t, strings.contains(output, "Missing"), "unicode cell content missing")
+	expected := `┌─────────────┬────────┐
+│ Status      │ Detail │
+├─────────────┼────────┤
+│ ✓ Available │ ok     │
+│ ✗ Missing   │ fail   │
+└─────────────┴────────┘
+`
+	testing.expect(
+		t,
+		output == expected,
+		fmt.tprintf(
+			"table output mismatch\n--- expected ---\n%s\n--- got ---\n%s\n",
+			expected,
+			output,
+		),
+	)
 }
Author	SHA1	Message	Date
Spencer Brower	623c2f5f29	docs: Removed completed TODOs.	2026-06-15 19:34:59 -04:00
Spencer Brower	5ea760a7fa	test: Table tests now view full output.	2026-06-15 19:28:56 -04:00
Spencer Brower	c5d578dd1b	test: commands now accept stdout/stderr fields.	2026-06-15 19:26:44 -04:00
Spencer Brower	a4417affa1	chore: Cleaned up code.	2026-06-15 16:45:36 -04:00